[FFmpeg-devel] [PATCH] Fix the build on OS X + clang

[David Conrad]

On Mar 7, 2010, at 8:54 AM, Ronald S. Bultje wrote:

> Hi,
> 
> On Mar 7, 2010, at 5:37 AM, Martin Storsj? <martin at martin.st> wrote:
>> On Sun, 7 Mar 2010, David Conrad wrote:
>>> On Mar 7, 2010, at 1:42 AM, M?ns Rullg?rd wrote:
>>>> David Conrad <lessen42 at gmail.com> writes:
>>>>> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
>>>>> index c7c6fc3..7403653 100644
>>>>> --- a/libavformat/rtsp.c
>>>>> +++ b/libavformat/rtsp.c
>>>>> @@ -21,6 +21,7 @@
>>>>> 
>>>>> /* needed by inet_aton() */
>>>>> #define _SVID_SOURCE
>>>>> +#define _DARWIN_C_SOURCE
>>>>> 
>>>>> #include "libavutil/base64.h"
>>>>> #include "libavutil/avstring.h"
>>>> 
>>>> This doesn't belong in rtsp.c, nor does the _SVID_SOURCE.  Maybe we
>>>> need to change something...
>>> 
>>> Something like this?
>> 
>> This is ok with me, but I'd say wait for Ronalds opinion, too.
>> 
>> Generally, I think the inet_aton usage in rtsp.c should be changed to use
>> getaddrinfo (with suitable flags) instead.
> 
> Agree. For now, temporarily, this hack is OK, I guess...

Applied