[FFmpeg-devel] [PATCH] Move av_open_input_file probe loop to its own method

[Stefano Sabatini]

On date Sunday 2010-03-07 12:48:45 -0500, MIcah Galizia encoded:
> On 10-03-07 05:52 AM, Stefano Sabatini wrote:
> >On date Saturday 2010-03-06 19:02:07 -0500, Micah F. Galizia encoded:
> >>On 10-03-06 06:17 PM, Michael Niedermayer wrote:
[...]
> >>>should be ok if tested
> >>
> >>I tested it in plain old ffmpeg, and with my shoutcast changes.
> >
> >Please test with make test, I tried it and it failed in
> >regtest-pbmpipe.
> >
> >cat pbmpipe.lavf.err
> >/home/stefano/src/ffmpeg.git/./tests/data/lavf/pbmpipe.pbm: Error while opening file
> 
> Thank you.  The attached patch fixes it.  The problem was that after
> the initial probe in av_open_input_file (with no actual probe data),
> I was setting the input format to NULL in ff_probe_input_buffer.
> Now all regression tests pass (make test).
> 
> Also, I have improved the commenting in internal.h.
> 
> Thanks again!

Patch applied, thanks for the fish.
-- 
FFmpeg = Friendly Fanciful Majestic Puristic Empowered Gnome