[FFmpeg-devel] [PATCH] Extend slicify filter to make it accept a parametric value

[Michael Niedermayer]

On Wed, Mar 10, 2010 at 12:14:09PM +0100, Stefano Sabatini wrote:
> On date Wednesday 2010-03-10 11:45:21 +0100, Michael Niedermayer encoded:
> > On Wed, Mar 10, 2010 at 01:49:00AM +0100, Stefano Sabatini wrote:
> > > Hi, as in subject.
> > > 
> > > This should be a great help for testing slicing.
> > [...]
> > > @@ -24,35 +24,74 @@
> > >   */
> > >  
> > >  #include "avfilter.h"
> > > +#include "libavutil/lfg.h"
> > >  #include "libavutil/pixdesc.h"
> > > +#include "libavcodec/eval.h"
> > 
> > you add a dependancy on lavc
> 
> libavfilter *already* depends on libavcodec (ff_fill_pointer).
> 
> And yes I plan to remove all the dependancies. 

removeing the dependancy is ok adding more is rejected.
Let us remember you do this to avoid
if(arg='r')  sliceheight=lcg()


eval() support in lavfi is welcome but this is the wrong time and wrong
approuch.
We have tons of critical issues we need to work on in lavfi
support in ffmpeg.c
enabling avfilter by default
running lavfi regression tests by default
direct rendering

especially enabling regression tests by default which requires avfilter to
be enabled by default and support in ffmpeg.c are prerequesits of any kind
of redesign
Thats said eval has more prerequesits like 
eval in lavutil which requires the eval API to be looked over.
and after all that we need to think on how to cleanly integrate eval() into
lavfi, calling eval litterally with huge amounts of code independatly in each
filter is not a good idea.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100310/77ebf220/attachment.pgp>