[FFmpeg-devel] [PATCH] Make binkaudio work with ff_float_to_int16_interleave_c

[Ronald S. Bultje]

Hi,

On Wed, Mar 10, 2010 at 5:46 AM, Martin Storsj? <martin at martin.st> wrote:
> The bink audio decoder produces distorted output if the
> float_to_int16_interleave function happens to be implemented by
> ff_float_to_int16_interleave_c. All other audio decoders using this
> function have special casing for the case when float_to_int16_interleave
> is implemented by ff_float_to_int16_interleave_c, adding a particular
> bias and scale factor.

Independent of the patch (I'm not maintainer), and maybe this is just
me, but why is this the case? This just smells like BBBBUUUUUUGGGGGGG
to me. Does the 1-cycle gain that you got through this really justify
the real problems that quite apparently result from it?

Ronald