[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

[Justin Ruggles]

James Darnley wrote:

> ping...
> 
> Another version attached.
> Added static to the two new functions only used in flacenc.c (thanks patcheck)
> Corrected the test filename due to a recent change
> 
> An updated patch for ogg files is attached too.
> 
> Some other questions.  Do I need to add an entry to the changelog?  Do
> I need to change a version number?

I think an entry in the Changelog would be good.

As for version bump, maybe micro version?  I think the addition of
metadata writing to a muxer is a noteworthy change.  Also, if a program
using lavf currently writes VorbisComment tags another way, it could
check the version number to decide whether it still needs to do so.

The FLAC muxer part looks good to me.

I also think the VorbisComment writer looks good, but I'm not metadata
maintainer.

-Justin