[FFmpeg-devel] [PATCH] Use the actual RTSP peer IP for RTP sessions

[Luca Abeni]

Hi Martin,

On 10/03/10 23:47, Martin Storsj? wrote:
[...]
> My opinion is that creating the SDP simply is a general utility function,
> the RTSP muxer could just as well use some simplified SDP generation
> function of its own, just looking at the individual AVStreams to set
> proper codec metadata. But that would be code duplication, so instead, we
> use the same SDP generation code that's exposed publicly through
> avf_sdp_create.
>
> This utility function doesn't have a flexible enough interface for this
> use case, but we don't need to expose the more flexible function outside
> of libavformat, it can be an internal function, ff_sdp_create.

Well, I might be completely wrong here, but...
I do not think that the current interface is not flexible enough (at 
least, regarding the "destination address" parameter - I admit that 
being able to easily set the control URL would be nice). In my opinions, 
it is just enforcing some consistency between the parameters (and I 
don't think that enforcing consistency is a lack of flexibility :).


			Luca