[FFmpeg-devel] [PATCH] Define AVMediaType in libavutil

Michael Niedermayer michaelni
Sun Mar 14 16:21:51 CET 2010


On Sun, Mar 14, 2010 at 04:03:14PM +0100, Stefano Sabatini wrote:
> On date Sunday 2010-03-14 14:30:12 +0100, Michael Niedermayer encoded:
> > On Sat, Mar 13, 2010 at 07:39:12PM +0100, Stefano Sabatini wrote:
> > > On date Saturday 2010-03-13 19:13:44 +0100, Michael Niedermayer encoded:
> > > > On Sat, Mar 13, 2010 at 04:10:04PM +0100, Stefano Sabatini wrote:
> > > > > Hi, see patch description.
> > > > > 
> > > > > This is meant mainly to remove one of the *compilation-time*
> > > > > dependancy of libavfilter on libavcodec.
> > > > > 
> > > > > I hope it is clear why this is desirable (note: currently we can
> > > > > already have the libavutil+libavfilter headers installed and not the
> > > > > libavcodec ones).
> > > > > 
> > > > > If this is OK I can replace all occurrences of CodecType with
> > > > > corresponding AVMediaType symbols and drop the CodecType definition,
> > > > > 
> > > > > *or*
> > > > > 
> > > > > keep an independent definition of CodecType.
> > > > > 
> > > > > Regards.
> > > > > -- 
> > > > > FFmpeg = Faithful & Fundamental Mortal Portentous Exciting Geek
> > > > 
> > > > >  libavcodec/avcodec.h |   18 +++++++++---------
> > > > >  libavutil/avutil.h   |   12 +++++++++++-
> > > > >  2 files changed, 20 insertions(+), 10 deletions(-)
> > > > > 23c583d2485a356073472b3805cec69d9b60bef2  0001-Define-enum-AVMediaType-and-make-enum-CodecType-depe.patch
> > > > > >From b007b145584c1e86eb3c10cc9b49f00cb12f18b5 Mon Sep 17 00:00:00 2001
> > > > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > > > Date: Sat, 13 Mar 2010 16:01:06 +0100
> > > > > Subject: [PATCH] Define enum AVMediaType and make enum CodecType depends on that.
> > > > 
> > > > iam mildly against this patch
> > > 
> > > Please elaborate.
> > 
> > codec->media is bikeshed
> 
> I agree that this is a bikeshed, but having to change the name,
> "media" is more adequate than "codec", which has a more specific
> use.
> 
> The type of a filter is a media type, not a codec type, while the type
> of a codec is a media type, that's why I prefer AVMediaType over
> AVCodecType.

well, if people want it ok, if just you want it, not ok :)
but make sure you dont break ABI/API before a major bump


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100314/4bb7b888/attachment.pgp>



More information about the ffmpeg-devel mailing list