[FFmpeg-devel] [PATCH] Support RTP/TCP in the RTSP muxer

[Martin Storsjö]

On Mon, 15 Mar 2010, Ronald S. Bultje wrote:

> On Mon, Mar 15, 2010 at 12:17 PM, Martin Storsj? <martin at martin.st> wrote:
> > On Mon, 15 Mar 2010, Ronald S. Bultje wrote:
> >> On Mon, Mar 15, 2010 at 11:50 AM, Martin Storsj? <martin at martin.st> wrote:
> >> Patch #2 seems pointless, why would you want to skip packets there
> >> instead of in read_reply()?
> >
> > If we skip the packets within read_reply, the function won't return until
> > it has actually received a RTSP reply. If there's only a interleaved
> > packet waiting on the socket, select will indicate that there's data to be
> > read, read_reply will skip that but block until it receives a RTSP reply,
> > which isn't coming anytime soon.
> >
> > So by doing it this way, we first notice that there's data to be read,
> > receive/skip the whole interleaved packet, and then recheck with select if
> > there's anything left to read, exiting the loop if there's nothing more to
> > process.
> 
> Ah, makes sense. Can you add a comment to the code that says this in
> 1-2 sentences? Looks good to me then, no comments on the patch itself?

Applied #1 and #2, with a comment in the code explaining the reasoning.

What patch did or did I not have any comments on (re your last clause 
above)?

// Martin