[FFmpeg-devel] theora depayloader

Martin Storsjö martin
Sat Mar 20 02:21:18 CET 2010


On Fri, 19 Mar 2010, Josh Allmann wrote:

> On 19 March 2010 05:23, Martin Storsj? <martin at martin.st> wrote:
> >
> > On Fri, 19 Mar 2010, Josh Allmann wrote:
> >
> >
> >> + ? ?ptr = codec->extradata = av_mallocz(length + length / 255 + 64);
> >
> > Doesn't extradata need FF_INPUT_BUFFER_PADDING_SIZE at the end?
> 
> I'm not sure, but since extradata is identical to vorbis, I'll
> investigate that when I refactor out common code.

Let me rephrase - if the vorbis code doesn't add padding to the extradata, 
it's a bug, no need to replicate it here. The vorbis code can be fixed 
and/or merged with parts of this later, but don't add more incorrectness 
just for uniformness :-)

// Martin



More information about the ffmpeg-devel mailing list