[FFmpeg-devel] [PATCH] Make av_open_input_file() return AVERROR_NOTSUPP rather than AV_NOFMT if the format is unknown / cannot be recognized.

Michael Niedermayer michaelni
Sun Mar 21 16:06:40 CET 2010


On Sat, Mar 20, 2010 at 12:50:35AM +0100, Stefano Sabatini wrote:
> On date Thursday 2010-03-18 03:41:20 +0100, Michael Niedermayer encoded:
> > On Thu, Mar 18, 2010 at 01:49:11AM +0100, Stefano Sabatini wrote:
> > > On date Wednesday 2010-03-17 15:51:57 +0100, Michael Niedermayer encoded:
> > > > On Wed, Mar 17, 2010 at 12:58:17AM +0100, Stefano Sabatini wrote:
> > > > > Hi, $subj.
> > > > > -- 
> > > > > FFmpeg = Free & Foolish Mastering Peaceful Embarassing Genius
> > > > 
> > > > >  utils.c |    2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 88370bd8e6975ccca60dd9b8f0c4d3ecb716c23a  0010-Make-av_open_input_file-return-AVERROR_NOTSUPP-rathe.patch
> > > > > >From 62564d9e6a5ec8be552cc94de6e50662c85bb7ff Mon Sep 17 00:00:00 2001
> > > > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > > > Date: Wed, 17 Mar 2010 00:36:45 +0100
> > > > > Subject: [PATCH 10/15] Make av_open_input_file() return AVERROR_NOTSUPP rather than AV_NOFMT
> > > > >  if the format is unknonw / cannot be recognized.
> > > > > 
> > > > > That was the only use of AVERROR_NOFMT, which is going to be dropped.
> > > > 
> > > > rejected
> > > > with this the semantics are really wrong
> > > > not supported implicates supportable, random undetected data is not
> > > > neccesarily supportable
> > > 
> > > The other idea was to use AVERROR_INVALIDDATA, but this too may not be
> > > correct as the format could be simply not supported by FFmpeg.
> > > 
> > > And we can consider bogus random data as something which is simply
> > > "not supported" by FFmpeg, although I recognize this is a somehow
> > > stretched interpretation.
> > 
> > I think i prefer AVERROR_INVALIDDATA, in the sense that 
> > the data is invalid within what the specific libav* binary supports
> 
> Updated.
> -- 
> FFmpeg = Fiendish and Furious Minimalistic Powerful Elastic Geisha

>  utils.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> d1103b3432d30ce4b6320b922654b84524a436ed  0007-Make-av_open_input_file-return-AVERROR_INVALIDDATA-r.patch
> >From 53b6d5e662c03b28bf5f8fc6cf732e0d8f1bc157 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Wed, 17 Mar 2010 00:36:45 +0100
> Subject: [PATCH 07/12] Make av_open_input_file() return AVERROR_INVALIDDATA rather than
>  AV_NOFMT if the format is unknown / cannot be recognized.
> 
> It is returned AVERROR_INVALIDDATA, in the sense that the data is
> invalid within what the specific libav* binary supports.
> 
> That was the only use of AVERROR_NOFMT, which is going to be dropped.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100321/9c972fd1/attachment.pgp>



More information about the ffmpeg-devel mailing list