[FFmpeg-devel] [PATCH] Define AVMediaType in libavutil

Justin Ruggles justin.ruggles
Sun Mar 21 19:09:23 CET 2010


Stefano Sabatini wrote:

> On date Sunday 2010-03-14 18:23:49 +0100, Stefano Sabatini encoded:
>> On date Sunday 2010-03-14 16:21:51 +0100, Michael Niedermayer encoded:
>>> On Sun, Mar 14, 2010 at 04:03:14PM +0100, Stefano Sabatini wrote:
>>>> On date Sunday 2010-03-14 14:30:12 +0100, Michael Niedermayer encoded:
>> [...]
>>>>> codec->media is bikeshed
>>>> I agree that this is a bikeshed, but having to change the name,
>>>> "media" is more adequate than "codec", which has a more specific
>>>> use.
>>>>
>>>> The type of a filter is a media type, not a codec type, while the type
>>>> of a codec is a media type, that's why I prefer AVMediaType over
>>>> AVCodecType.
>>> well, if people want it ok, if just you want it, not ok :)
>>> but make sure you dont break ABI/API before a major bump
>> Well I'll wait no less than a week, people are encouraged to express
>> their opinion, if there will be no opposition I'll apply the patch.
> 
> Reminder, I'll apply this in three days if there are no objections,
> speak now if you have them.
> 
> If you agree, then please say so, so we're sure I'm not the only one
> willing this ;-).

It's a huge patch, but I slightly agree.  The naming is better.

-Justin




More information about the ffmpeg-devel mailing list