[FFmpeg-devel] [PATCH] Screen frame grabbing for Win32 platform (bump)

[Christophe Gisquet]

2010/3/24 Michael Niedermayer <michaelni at gmx.at>:
> i dont see why non blocking shouldnt be supported so please add support for
> it

I misunderstood what was actually requested. Ramiro explained, and all
should be in order now.

As a proof of those extended explanations, here's an updated patch.

0) Passed through patcheck
1) full desktop is not assumed as default; one must specify it
2) name dealloc checked
3) less spaming when cursor displaying has errors
4) libavdevice minor version bump
5) non-blocking read

If 5) is ok, the same fix should be applied to x11grab.

Also, considering that the AVFormatParameters passed to read_header
shouldn't be modified, it seems having it const is better? Not sure
what it entails for non-devices.

Best regards,
Kurosu