[FFmpeg-devel] [PATCH] av_log_missing_feature_once

[Michael Niedermayer]

On Wed, Mar 24, 2010 at 03:51:47PM -0400, Alexander Strange wrote:
> 
> On Mar 18, 2010, at 9:23 PM, Michael Niedermayer wrote:
> 
> > On Thu, Mar 18, 2010 at 05:45:41PM -0400, Alexander Strange wrote:
> >> This prevents HE-AACv2 files from printing warnings about parametric stereo constantly.
> >> 
> >> It was suggested that every av_log_missing_feature call should only happen once, but that would mean adding a variable for each one (whether static or a context variable) and I think most of them are rare anyway.
> >> 
> > 
> > i think we need a context variable, a function like in this patch that
> > simplifies it is of course a good idea.
> > but without such variable it is printed just once in the lifetime of an
> > application. This is all fine for a application that plays one file once
> > but something like xmms that may run for months really would misbehave quite
> > a bit.
> 
> Here it is with a context variable.
> 

>  avcodec.h |    8 ++++++++
>  utils.c   |    8 ++++++++
>  2 files changed, 16 insertions(+)
> 65007674a681aea18a432600de85c9f7d43a6b1b  0001-Add-a-function-to-help-avoid-repeatedly-printing-mis.patch
> From 2ed6b004dcde94c7ba80597e9d3cff8fde471572 Mon Sep 17 00:00:00 2001
> From: Alexander Strange <astrange at ithinksw.com>
> Date: Wed, 17 Mar 2010 14:51:20 -0400
> Subject: [PATCH 1/2] Add a function to help avoid repeatedly printing missing feature warnings
> 
> ---
>  libavcodec/avcodec.h |    8 ++++++++
>  libavcodec/utils.c   |    8 ++++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)

ok

[...]

>  aacsbr.c |    2 +-
>  sbr.h    |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> cfec8e9989044f7189f95965e53249841567b94e  0002-aac-Use-av_log_missing_feature_once-for-parametric-s.patch
> From f6e401223717eafe4e467c80ff53badc958b16ad Mon Sep 17 00:00:00 2001
> From: Alexander Strange <astrange at ithinksw.com>
> Date: Wed, 17 Mar 2010 14:51:59 -0400
> Subject: [PATCH 2/2] aac: Use av_log_missing_feature_once() for parametric stereo

appears to have been rejected by the maintainer

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100324/36e8b9a0/attachment.pgp>