[FFmpeg-devel] [PATCH] libavformat: Don't return errors if select is interrupted

[Michael Niedermayer]

On Fri, Mar 26, 2010 at 09:43:13AM +0200, Martin Storsj? wrote:
> On Fri, 26 Mar 2010, Michael Niedermayer wrote:
> 
> > On Fri, Mar 05, 2010 at 11:00:32AM +0200, Martin Storsj? wrote:
> > [...]
> > > diff --git a/libavformat/tcp.c b/libavformat/tcp.c
> > > index a8cf80f..20e8acb 100644
> > > --- a/libavformat/tcp.c
> > > +++ b/libavformat/tcp.c
> > > @@ -149,6 +149,8 @@ static int tcp_read(URLContext *h, uint8_t *buf, int size)
> > >                      return AVERROR(ff_neterrno());
> > >              } else return len;
> > >          } else if (ret < 0) {
> > > +            if (ff_neterrno() == FF_NETERROR(EINTR))
> > > +                continue;
> > >              return -1;
> > >          }
> > >      }
> > 
> > should not many of these also check url_interrupt_cb() before continue?
> 
> Yes, but that's done as the first thing in the loop, after the continue, 
> so it's not necessary to do it here.

ok then i have no furher comment if thats taken care of in all cases
or was there some specific question ronald wanted me to awnser?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100326/ec5b2332/attachment.pgp>