[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Mohamed Naufal]

On 27 March 2010 07:26, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Mar 27, 2010 at 07:08:11AM +0530, Mohamed Naufal wrote:
>> On 27 March 2010 06:35, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Sat, Mar 27, 2010 at 01:18:51AM +0530, Mohamed Naufal wrote:
>> >> On 26 March 2010 21:06, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >>
>> >>
>> >> [...]
>> >>
>> >> >> + * Take s->dstptr to the next macroblock in sequence.
>> >> >> + */
>> >> >> +static void yop_next_macroblock(YopDecContext *s)
>> >> >> +{
>> >> >> + ? ?// If we are advancing to the next row of macroblocks
>> >> >> + ? ?if (s->row_pos == s->frame.linesize[0] - 2) {
>> >> >> + ? ? ? ?s->dstptr ?+= s->frame.linesize[0];
>> >> >
>> >> > this looks like it assumes width == linesize
>> >> > this is not guranteed by get_buffer()
>> >> >
>> >>
>> >>
>> >> But width is assigned to linesize after get_buffer().
>> >
>> > not pretty but i see this probably isnt easy to avoid
>> >
>> > did you test the code with damaged files (tools/trasher)
>> > it shouldnt crash or hang with it
>> >
>> > except that its probably ok
>> >
>>
>> Finally! ;)
>> Checked. Works without problems.
>> Also would it be appropriate to add my name to copyright?
>
> i think so, yes
>
> [...]
>

Patch attached.

Thanks,
Naufal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yop.patch
Type: text/x-patch
Size: 18672 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100327/45124ec2/attachment.bin>