[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Ronald S. Bultje]

Hi,

On Sat, Mar 27, 2010 at 11:28 AM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Saturday 2010-03-27 15:10:01 +0100, Reimar D?ffinger encoded:
>> On Sat, Mar 27, 2010 at 03:05:34PM +0100, Stefano Sabatini wrote:
>> > if ((ret = avctx->get_buffer(avctx, &s->frame) < 0) {
>>
>> Could we please get those assignments in ifs banned?
>> In 99% of cases they only make the code harder to read
>> without even the slightest advantage I can see.
[..]
> And this is a rather bikesheddish issue, I suggest to just let the
> code writer/maintainer choose the style which suits her better, at
> least for this particular idiomatic syntax.

Agree, I like them in specific cases (I've overused them in the past,
I admit) where you have several very short lines.

Btw the one above wouldn't work, it lacks one closing ")".

Ronald