[FFmpeg-devel] [PATCH] share xiph rtp code

[Luca Barbato]

On 03/28/2010 10:24 AM, Josh Allmann wrote:
> Hi,
> 
> $subject
> 
> Everything can be shared between theora and vorbis, so I moved code
> into rtpdec_xiph.c/h, and removed the old rtpdec_theora and
> rtpdec_vorbis files.
> With this, the vorbis depayloader inherits all the features that were
> added to theora's, including dropped-packet handling, split frames,
> and multiple frames per packet.
> 
> This patch series is dependent, one after the other.
> 
> 001: moves the original rtpdec_theora code to rtpdec_xiph, and updates
> the makefile and related accordingly.
> 
> 002: renaming and other cosmetic changes to rtpdec_xiph
> 
> 003: moves vorbis depayloader to rtpdec_xiph
> 
> Tested this with feng and gst-rtsp, and things seem to work but if
> someone could double-check the audio for me that'd be great.

the main difference between vorbis and theora in the producer side is
due the fact you need to pick some information from the extradata to get
the right timings from the granulepos. iirc the receiver side should be
identical so it looks fine.

The output is completely broken? trying to do a streamcopy results in a
broken vorbis?

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero