[FFmpeg-devel] [PATCH] wmaprodec rewrite interleaving

Ronald S. Bultje rsbultje
Mon Mar 29 19:38:31 CEST 2010


Hi,

On Mon, Mar 29, 2010 at 4:12 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Mar 28, 2010 at 10:30:46PM -0400, Ronald S. Bultje wrote:
>> On Sat, Mar 27, 2010 at 5:20 PM, Sascha Sommer <saschasommer at freenet.de> wrote:
>> > Am Samstag 27 M?rz 2010 17:17:53 schrieb Ronald S. Bultje:
>> >> the interleaving code right now is plain ugly, this is an attempt to
>> >> make it slightly less ugly. But honestly someone should write a DSP
>> >> function for this (and that's not me), because other decoders (e.g.
>> >> atrac1) do similar silly stuff and I'm sure that can be optimized.
>> >
>> > The for -> while loop change is ok but please split the variable
>> > initialization into multiple instructions.
>>
>> OK, see attached for a better patch then. Let me know if this is OK.
>> (I can commit the merge variable declaration + initial value in a
>> separate commit if you want.)
>>
>> Ronald
>
>> ?wmaprodec.c | ? ?8 +++-----
>> ?1 file changed, 3 insertions(+), 5 deletions(-)
>> cc4043dca88f10d943cd509119f6ca301223b6b8 ?simplify_wmaprodec_interleaving_code.patch
>
> ok

Applied.

Ronald



More information about the ffmpeg-devel mailing list