[FFmpeg-devel] [PATCH] pnm parser crashes on corrupted frames

[Howard Chu]

Baptiste Coudurier wrote:
> Hi,
>
> On 03/28/2010 01:28 PM, Howard Chu wrote:
>> Unfortunately I don't have a sample file. The stream of samples was
>> produced by gource; they were generated on the fly and written through a
>> pipe to ffmpeg. The deeper problem is why was gource producing corrupted
>> frames, but that's not for this forum. If you feel like it's worth
>> chasing down to produce a sample, you could run gource on your own
>> source repo to make a movie. (I used the OpenLDAP repo.
>> http://www.youtube.com/watch?v=4sClZGLZ6dY )

> It seems to me that you don't care much about what I explained in the
> bug tracker:

I'm sorry, I had completely forgotten that I had already reported this.

> On 01/19/2010 06:43 AM, Howard Chu wrote:
>   >
>   >  Howard Chu<hyc at symas.com>   added the comment:
>   >
>   >  Looks like it's just a spurious message from the pnm parser, the
>   >  parser will correctly rebuffer and retry when it gets an incomplete
>   >  record. This trivial patch shuts up the error message:
>
> check_dimensions is here to check height. I think the correct fix is to
> make pnm_get return the number of bytes read and fail if it's<  requested.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/