[FFmpeg-devel] [PATCH] Fix non-rounding up to next 16-bit aligned bug in IFF decoder

[Måns Rullgård]

Sebastian Vater <cdgs.basty at googlemail.com> writes:

> M?ns Rullg?rd a ?crit :
>> Sebastian Vater <cdgs.basty at googlemail.com> writes:
>>
>>   
>>> Just tested on PowerPC big-endian machine:
>>> Converting to BMP and gwenviewing the BMP worked fine.
>>>     
>>
>> That's not how you test decoders.  The correct way is to do something
>> like this:
>>
>> $ ./ffmpeg -i input -f rawvideo - | md5sum
>>
>> If the md5sum changes, there's an error somewhere.  A small error will
>> not be obvious through visual inspection only.
>>   
>
> I did that both with:
>
> $ ./ffmpeg -i input -f rawvideo - | md5sum
>
> and with:
>
> $ ./ffmpeg -i input - | md5sum
>
> If I ommit rawvideo, the two md5sum's match on be/le...

That doesn't work here.

> When I use rawvideo, they differ only in the palette data at the end.
> The palette data is written as ARGB on a be CPU and BGRA on le CPU.

You could specify an endian-independent pixel format with -pix_fmt.

-- 
M?ns Rullg?rd
mans at mansr.com