[FFmpeg-devel] [PATCH] MPEG-4 Parametric Stereo decoder

[Diego Biurrun]

On Thu, May 20, 2010 at 01:51:41PM -0400, Alex Converse wrote:
> Yes there are some places where it can be further optimized but I'm
> losing motivation on this quickly so perhaps some review will respark
> my interest.

> --- /dev/null
> +++ b/libavcodec/ps.c
> @@ -0,0 +1,1161 @@
> +
> +static av_noinline void stereo_processing(PSContext *ps, float (*l)[32][2], float (*r)[32][2], int is34)

There are a bunch of long lines that you could easily break.

> +static av_cold void ps_init_dec()

ps_init_dec(void)

> +av_cold void ff_ps_init(void) {

{ on the next line

> --- /dev/null
> +++ b/libavcodec/psdata.c
> @@ -0,0 +1,1386 @@
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +static const uint8_t huff_iid_df1_bits[] = {
> +    18, 18, 18, 18, 18, 18, 18, 18, 18, 17, 18, 17, 17, 16, 16, 15, 14, 14,
> +    13, 12, 12, 11, 10, 10,  8,  7,  6,  5,  4,  3,  1,  3,  4,  5,  6,  7,
> +     8,  9, 10, 11, 11, 12, 13, 14, 14, 15, 16, 16, 17, 17, 18, 17, 18, 18,
> +    18, 18, 18, 18, 18, 18, 18,
> +};

This is missing a stdint.h #include.

Diego