[FFmpeg-devel] [PATCH 11/13] Make nut muxer try to get the codec id from ff_raw_pixelFormatTags if ff_codec_get_id() cannot find it.

Stefano Sabatini stefano.sabatini-lala
Sat May 22 18:04:35 CEST 2010


On date Friday 2010-05-21 19:45:22 +0200, Michael Niedermayer encoded:
> On Fri, May 21, 2010 at 01:19:06AM +0200, Stefano Sabatini wrote:
> > On date Monday 2010-05-17 01:15:26 +0200, Michael Niedermayer encoded:
> > > On Sat, May 15, 2010 at 04:43:31PM +0200, Stefano Sabatini wrote:
> > > > On date Monday 2010-05-10 00:14:47 +0200, Michael Niedermayer encoded:
> > > > > On Sun, May 09, 2010 at 04:29:29PM +0200, Stefano Sabatini wrote:
> [...]
> 
> > > > > the codec tag/id mapping must be in AVOutputFormat.codec_tag
> > > > 
> > > > Yes but what about codec tag/pix_fmt mapping?
> > > 
> > > the pixel format is more or less a decoder output property
> > > and an encoder input property
> > > its not really a demuxer level property.
> > 
> > The code here tries to understand if the codec id is RAWVIDEO, is not
> > trying to get the pixel format (that is computed in rawdec.c), but in
> > order to do that it's using the mapping in ff_raw_pixelFormatTags.
> > 
> > Alternatively we could just assume RAWVIDEO by default, really can't
> > say if that would be better.
> 
> as my initial reply:
> "the codec tag/id mapping must be in AVOutputFormat.codec_tag"
> or for demuxers in AVInputFormat.codec_tag

codec tag/id mapping also depends on the type of codec, so this can be
done for example in the nut demuxer, also currently it is not possible
to map codec id <-> codec type.

Attached another variant.
-- 
FFmpeg = Faithless and Fantastic Miracolous Portentous Entertaining Genius



More information about the ffmpeg-devel mailing list