[FFmpeg-devel] [PATCH] fix unconditional H264 references to SVQ3

[Alexander Strange]

On May 22, 2010, at 6:50 PM, matthieu castet wrote:

> Alexander Strange <astrange <at> ithinksw.com> writes:
> 
>> 
>> 
>> On May 22, 2010, at 8:54 AM, M?ns Rullg?rd wrote:
>> 
>>> 
>>> Turning off all optimisation is not supported.  Specifically, dead
>>> code elimination must always be performed.
> Doesn't configure support --disable-optimizations ?
> 
>> 
>> gcc removes if (0) at -O0. Maybe 'int is_h264 = 1; if (!is_h264)' is too much
> for it?
>> I wouldn't mind moving CONFIG_SVQ3_DECODER into the if.
>> 
> That's very fragile (think of using another compiler). The proper fix is to
> define dummy functions.

If some other compiler doesn't remove dead code at -O0, it won't be able to compile many other programs anyway.

GNU uses if (0):
http://www.gnu.org/prep/standards/standards.html#Conditional-Compilation