[FFmpeg-devel] [PATCH] Make ff_url_split() and ff_url_join() public.

[Martin Storsjö]

On Sat, 22 May 2010, Stefano Sabatini wrote:

> On date Saturday 2010-05-22 21:57:21 +0200, Stefano Sabatini encoded:
> > ---
> >  libavformat/avformat.h  |   45 ++++++++++++++++++++++++++++++++++++++++++++
> >  libavformat/internal.h  |   42 +++-------------------------------------
> >  libavformat/rtmpproto.c |    4 +-
> >  libavformat/utils.c     |   48 +++++++++++++++++++++++++++++++++++++++++-----
> >  4 files changed, 93 insertions(+), 46 deletions(-)
> 
> In particular this fixes the infamous ffserver warning.

That could actually be fixed by simply including libavformat/internal.h, 
too - but that's adding more depenency on lavf-internal stuff, when it in 
this case very well could be public instead, as you're proposing.

For what it's worth, a dynamically linked build of ffserver references 
these non-public functions from lavf:

    ff_inet_aton
    ff_socket_nonblock
    ff_url_split
    ff_rtsp_parse_line
    rtp_get_local_rtcp_port
    rtp_get_local_rtp_port

> And maybe the names:
> av_split_url()
> av_join_url()
> 
> would be even better.

Hmm, I'm not sure, somehow I like the current "hierarchical" naming with 
having ff_url_* as a prefix.

Ronald, what do you think about the naming?

// Martin