[FFmpeg-devel] [PATCH] IFF: Add error checking to byterun1 decoder

Ronald S. Bultje rsbultje
Wed May 26 17:28:30 CEST 2010


Hi,

On Wed, May 26, 2010 at 11:24 AM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> Ronald S. Bultje a ?crit :
>> Then in the loop, you can add more if (buf>=end) break; checks, and at
>> the end of the function you can add the actual error message which is
>> triplicated throughout the loop now (if (buf >= end) { av_log();
>> return error; }
>
> That sounds much better, indeed, yes.
> Another possibility would be though to change the error messages in each
> (i.e. make them more detailed), what do you think of this?

I'm no sure how useful it is for the user to know wha part failed. In
all cases, it means the file cannot be decoded.

Ronald



More information about the ffmpeg-devel mailing list