[FFmpeg-devel] Patch for issue 1973 (targa decoder crash on corrupted file)

Kostya kostya.shishkov
Mon May 31 08:05:31 CEST 2010


On Sun, May 30, 2010 at 08:51:00PM +0200, Jean-Daniel Dupas wrote:
> 
> Le 30 mai 2010 ? 20:34, Kostya a ?crit :
> 
> > On Sun, May 30, 2010 at 07:29:03PM +0200, Jean-Daniel Dupas wrote:
> >> 
> > [...]
> >>> 
> >>> Still there is weird indentation of two spaces on some lines. And in
> >>> your check macro "return -1" is missing 4 spaces on indent.
> >> 
> >> Sorry for that. This time I hope it's good.
> > 
> > Still wrong in check for image size. But you're almost there.
> 
> Argh, another try. It's hard to go against the habits. I'm used to 2 spaces ;-) .
 
Please remove spaces between if (x) {, now it's inconsitent in your
patch (you have "if (x) {", "if(x) {" and "if(x){", I want the latter
and the same for "else" clause). After that it should be totally OK.



More information about the ffmpeg-devel mailing list