[FFmpeg-devel] [PATCH] improve H.263 probe

[Michael Niedermayer]

On Wed, Nov 17, 2010 at 10:51:47PM +0100, Reimar D?ffinger wrote:
> Hello,
> related to issue2363.
> If there is only one single frame raw MPEG-2 and H.263 detection conflict
> and result in a negative value.
> Below patch fixes the given sample, however I guess it might result in
> single-frame H.263 files not being detected correctly...
> Opinions/ideas?
> Index: ffmpeg/libavformat/h263dec.c
> ===================================================================
> --- ffmpeg/libavformat/h263dec.c        (revision 25760)
> +++ ffmpeg/libavformat/h263dec.c        (working copy)
> @@ -60,7 +60,7 @@
>      if(valid_psc > 2*invalid_psc + 2*res_change + 3){
>          return 50;
>      }else if(valid_psc > 2*invalid_psc)
> -        return 25;
> +        return valid_psc > 1 ? 25 : 15;

maybe testing if the psc is the first thing in the frame could help?
as a h263 frame that conatins just a psc is not that odd but one that
starts after junk and has then no second psc is quite odd

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101118/c57f8706/attachment.pgp>