[FFmpeg-devel] [PATCH] Implement robust parsing in aspect filters.

Michael Niedermayer michaelni
Fri Nov 19 23:31:24 CET 2010


On Fri, Nov 19, 2010 at 05:15:05PM +0100, Stefano Sabatini wrote:
> On date Friday 2010-11-19 01:59:16 +0100, Michael Niedermayer encoded:
> > On Fri, Nov 19, 2010 at 01:45:01AM +0100, Stefano Sabatini wrote:
> > > On date Friday 2010-11-19 01:24:59 +0100, Michael Niedermayer encoded:
> > > > On Thu, Nov 18, 2010 at 10:33:23PM +0100, Stefano Sabatini wrote:
> > > > > ---
> > > > >  libavfilter/vf_aspect.c |   27 +++++++++++++++++----------
> > > > >  1 files changed, 17 insertions(+), 10 deletions(-)
> > > > 
> > > > Mising explanation of what thix fixes
> > > 
> > > aspect=1foo
> > > aspect=1:foo
> > > aspect=1:2foo
> > > aspect=1:3:foo
> > 
> > so put a %c at the end of the scanf string and check for == instead of <
> > thats much simpler and a cleaner patch too
> 
> Updated.
> -- 
> FFmpeg = Fanciful & Fascinating Mastering Proud Ecletic Gadget

>  vf_aspect.c |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 6b8c999a4bbc72c302e3d55984f35f646cfcd392  0004-Implement-robust-parsing-in-aspect-filters.patch
> From 90def771e16baa37883427131a9fae374c3d7c14 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Thu, 18 Nov 2010 21:33:19 +0100
> Subject: [PATCH] Implement robust parsing in aspect filters.

lgtm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101119/25aa2282/attachment.pgp>



More information about the ffmpeg-devel mailing list