[FFmpeg-devel] [PATCH] FLAC parser

Michael Niedermayer michaelni
Tue Nov 30 01:59:01 CET 2010


On Wed, Nov 24, 2010 at 11:44:34PM +0100, Michael Chinen wrote:
> On Tue, Nov 23, 2010 at 10:25 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Nov 22, 2010 at 05:19:23PM -0500, Justin Ruggles wrote:
[...]
> >> As for the AV_LOG_MAX patch, I think it's good but Michael N. needs to
> >> ok it.
> >
> > probably a max of 127 should be more than enough
> 
> Ok, here is the updated patches with comment to flac_read_fifo_wrap,
> changelog, and minor version bump.
> 
> Michael

[...]
> @@ -109,6 +109,12 @@ typedef struct {
>  #define AV_LOG_DEBUG    48
>  
>  /**
> + * The maximum AV_LOG value.
> + * This can be useful as an offset to silence the log messages
> + **/
> +#define AV_LOG_MAX      255

thats not 127 but rethinking i see no need for this, offseting by appropriate
values for the code used is better because with several levels of calls there can
be no globally correct max/min offset

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101130/e2aaa4a2/attachment.pgp>



More information about the ffmpeg-devel mailing list