[FFmpeg-devel] [PATCH] Google WebP support

Pascal Massimino pascal.massimino
Sun Oct 3 11:46:57 CEST 2010


Diego,

On Sat, Oct 2, 2010 at 8:32 AM, Diego Biurrun <diego at biurrun.de> wrote:

> On Thu, Sep 30, 2010 at 03:55:11PM -0700, Pascal Massimino wrote:
> > On Thu, Sep 30, 2010 at 3:53 PM, Pascal Massimino <
> > pascal.massimino at gmail.com> wrote:
> >
> > > On Thu, Sep 30, 2010 at 3:52 PM, Mike Melanson <mike at multimedia.cx>
> wrote:
> > >
> > >> Google released a new image format called WebP. It's basically a VP8
> > >> golden frame wrapped with a 20-byte header. Attached is a first pass
> at
> > >> support. Here is a ready-made sample:
> > >>
> > >> http://samples.mplayerhq.hu/image-samples/webp/
> > >>
> > > what about  http://pastebin.com/FbUvG77M
> > >
> > attached, too. That's easier
> >
> > --- libavformat/Makefile      (revision 25217)
> > +++ libavformat/Makefile      (working copy)
> > @@ -277,6 +277,7 @@
> > +OBJS-$(CONFIG_WEBP_MUXER)                += webp.o
>
> Since this is compiled conditionally...
>
> > --- libavformat/webp.c        (revision 0)
> > +++ libavformat/webp.c        (revision 0)
> > @@ -0,0 +1,217 @@
> > +
> > +#include "avformat.h"
> > +#include "riff.h"
> > +
> > +#ifdef CONFIG_WEBP_MUXER
>
> ...this #ifdef is unnecessary.
>
> > +    if (s->nb_streams != 1)
>
> if (...) {
>
> same below, more nits for you to notice on your own ;)
>
> > +#endif  /* CONFIG_WEBP_MUXER */
> > +
> > +#if CONFIG_WEBP_DEMUXER
>
> Hmm, it seems that the Makefile entry is incomplete..
>

 should be fixed in attached patch...

skal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_webp_ffmpeg.diff
Type: application/octet-stream
Size: 7528 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101003/ccdf447c/attachment.obj>



More information about the ffmpeg-devel mailing list