[FFmpeg-devel] [PATCH] Add a time_base field to AVFilterPad.

Stefano Sabatini stefano.sabatini-lala
Wed Oct 6 20:20:18 CEST 2010


On date Wednesday 2010-10-06 18:19:35 +0200, Michael Niedermayer encoded:
> On Wed, Oct 06, 2010 at 06:12:17PM +0200, Stefano Sabatini wrote:
> > On date Wednesday 2010-10-06 12:13:42 +0200, Michael Niedermayer encoded:
> > > On Wed, Oct 06, 2010 at 10:57:47AM +0200, Stefano Sabatini wrote:
> > > > > > > > > your code makes no sense
> > > > > > > > > with a/b and c/d
> > > > > > > > > 
> > > > > > > > > you need something like:
> > > 
> > > > > > > > > reduce(gcd(ad,cb)/bd)
> > > [...]
> > > > Reducing tb1 and tb2 should solve the issue in this case.
> > > 
> > > why dont you use what i suggest?
> > 
> > (because I was trying to understand the math behind)
> 
> gcd(a/b, c/d)
> gcd(a/b, c/d)*bd / bd
> gcd(abd/b, cbd/d) / bd
> gcd(ad, cb) / bd
> 
> 
> > 
> > So the code is:
> 
> should be ok, a test cant hurt of course

I suppose it is an OK for the patch mentioned in the subject, which
I'm attaching again, the sample code was belonging to my local working
copy of the overlay filter (still not ready for review).

Regards.
-- 
FFmpeg = Fascinating Fast MultiPurpose Elaborated Gnome



More information about the ffmpeg-devel mailing list