[FFmpeg-devel] [PATCH 3/3] Export metadata in the generic format.

Michael Niedermayer michaelni
Thu Oct 7 01:10:00 CEST 2010

On Wed, Oct 06, 2010 at 03:37:06PM -0700, Baptiste Coudurier wrote:
> On 10/05/2010 02:54 PM, Michael Niedermayer wrote:
>> On Tue, Oct 05, 2010 at 10:05:48PM +0200, Aurelien Jacobs wrote:
>> [...]
>>> Maybe we could solve this problem in a simpler way by just moving
>>> AV(In/Out)putFormat.metadata_conv to AVMetadata.conv.
>>> When reading metadata out of a file, the demuxer would set
>>> AVMetadata.conv to the appropriate conversion table.
>>> Then we just have to change to av_metadata_conv() calls to read this new
>>> pointer instead of the old one.
>> doesnt work as you can have metadata from multiple sources like
>> id3 and ogg in the same file
> Well, WTF. How is it handled currently ? Are both native tags exported  
> and which conversion table is used in that case ?

i think both are exported with the conv table from the format aka not the
id3 table

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101007/4ccc80a7/attachment.pgp>

More information about the ffmpeg-devel mailing list