[FFmpeg-devel] [PATCH 2/2] Put the code for showing input and output streams and mapping in a separate function show_format_map().

[Michael Niedermayer]

On Sat, Oct 16, 2010 at 04:59:53PM +0200, Stefano Sabatini wrote:
> Improve readability and decrease the size of the still huge
> transcode_init() function.
> ---
>  ffmpeg.c |   53 ++++++++++++++++++++++++++++++-----------------------
>  1 files changed, 30 insertions(+), 23 deletions(-)
> 
> diff --git a/ffmpeg.c b/ffmpeg.c
> index 045e2d5..acd136d 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -1935,6 +1935,35 @@ static AVInputStream **ist_table;
>  static AVOutputStream **ost_table;
>  static AVInputFile *file_table;
>  
> +static void show_format_map(void)

its ugly (and not only that but it also has practical issues)
to pass void as argument and then use random global variables as arguments

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101016/23dbf010/attachment.pgp>