[FFmpeg-devel] [RFC] Remove -crop* ffmpeg options

[Michael Niedermayer]

On Sat, Oct 16, 2010 at 10:14:31PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2010-07-27 18:37:03 -0700, Baptiste Coudurier encoded:
> > On 7/27/10 4:40 PM, Michael Niedermayer wrote:
> > >On Tue, Jul 27, 2010 at 07:08:18PM +0200, Stefano Sabatini wrote:
> > >>Hi all,
> > >>
> > >>these are more than 100 lines of obfuscated code that make more
> > >>difficult to hack/understand the code of ffmpeg.
> > >>This is going to broke many scripts, so we may provide an error
> > >>message, similiar to what is issued for the -pad* options.
> > >>
> > >>Is someone against?
> > >
> > >iam slightly in favor of removing them
> > 
> > I'm in favor as well, replace the func with one that says "Please
> > use -vf crop" or something similar.
> 
> See attached patch.
> 
> BTW I noted that make test with --disable-avfilter fails the
> lavf-mxf_d10 test which uses -vf pad.
> 
> Regards.
> -- 
> FFmpeg = Free and Fierce Multipurpose Peaceless Enlightened Gem

>  doc/ffmpeg-doc.texi |   15 ++--
>  ffmpeg.c            |  175 +++++-----------------------------------------------
>  2 files changed, 27 insertions(+), 163 deletions(-)
> 0e21e824cdf35dd6b3bb54afe6952532b2aa2a6e  0001-Remove-crop-options.patch
> From 64394ce21826cd41eaeb951ce3e4621575c69a69 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sat, 16 Oct 2010 22:07:19 +0200
> Subject: [PATCH] Remove -crop* options.
> 
> Users are required to use the libavfilter crop filter.

[...]
> - at item -cropright @var{size} (deprecated - use the crop filter instead)
> -Set right crop band size (in pixels).
> + at item -croptop @var{size}
> + at item -cropbottom @var{size}
> + at item -cropleft @var{size}
> + at item -cropright @var{size}
> +All the crop options have been removed. Use -vf
> +pad=width:height:x:y:color instead.

pad not crop?


also make sure that a video that changes width/height does not behave worse
than before

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101017/bb2901e3/attachment.pgp>