[FFmpeg-devel] [RFC] Remove -crop* ffmpeg options

[Stefano Sabatini]

On date Sunday 2010-10-17 10:52:09 +0200, Michael Niedermayer encoded:
> On Sat, Oct 16, 2010 at 10:14:31PM +0200, Stefano Sabatini wrote:
[...]
> >  doc/ffmpeg-doc.texi |   15 ++--
> >  ffmpeg.c            |  175 +++++-----------------------------------------------
> >  2 files changed, 27 insertions(+), 163 deletions(-)
> > 0e21e824cdf35dd6b3bb54afe6952532b2aa2a6e  0001-Remove-crop-options.patch
> > From 64394ce21826cd41eaeb951ce3e4621575c69a69 Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > Date: Sat, 16 Oct 2010 22:07:19 +0200
> > Subject: [PATCH] Remove -crop* options.
> > 
> > Users are required to use the libavfilter crop filter.
> 
> [...]
> > - at item -cropright @var{size} (deprecated - use the crop filter instead)
> > -Set right crop band size (in pixels).
> > + at item -croptop @var{size}
> > + at item -cropbottom @var{size}
> > + at item -cropleft @var{size}
> > + at item -cropright @var{size}
> > +All the crop options have been removed. Use -vf
> > +pad=width:height:x:y:color instead.
> 
> pad not crop?
> 
> 
> also make sure that a video that changes width/height does not behave worse
> than before

Not worse than before, with --disable-avfilter it works as before
(video is correctly rescaled), with --enable-avfilter a lateral noise
band is show on the right when the video is rescaled.

Tested with size_change.nsv.

I'll apply it soon.

Regards.
-- 
FFmpeg = Fascinating & Free Murdering Practical EniGma