[FFmpeg-devel] [PATCH 1/3] refactor the actual aac decoding code into its own function

Ronald S. Bultje rsbultje
Mon Oct 18 19:42:10 CEST 2010


Hi,

On Mon, Oct 18, 2010 at 1:37 PM, Janne Grunau <janne-ffmpeg at jannau.net> wrote:
> aac_decode_frame() remains as AVPacket handling a wrapper. The actual
> decoding function takes a GetBitContext as input and will be used be the
> AAC LATM decoder to avoid copying the unaligned AAC bitstream.

I just want to note that I have a higher-than-average interest in this
concept, since this may be useful for wmapro-in-wmavoice as well.
Quite literally, this is a wmapro frame in a wmavoice bitstream
wrapper (i.e. a single bit before the wmapro frame that tells me that
it is _not_ a wmavoice frame, but a wmapro frame), which means I can't
literally call the wmapro decoder because the data is no longer
byte-aligned (same as for aac/latm here), and also the wmavoice
decoder would need to know how many bits, not bytes, were consumed
from the input by the wmapro decoder... If this patch is acceptable, I
may do the same for the wmapro decoding function. (My original plan
was to do decoder chaining and I hadn't figured out how to do the
not-byte-aligned thing yet.)

Ronald



More information about the ffmpeg-devel mailing list