[FFmpeg-devel] [PATCH] -force_key_frames option

[Stefano Sabatini]

On date Sunday 2010-10-17 01:13:58 +0200, Michael Niedermayer encoded:
> On Sat, Oct 16, 2010 at 08:39:22PM +0200, Nicolas George wrote:
> > > *ffmpeg* option, also maybe -forced_key_frame is more useful (check
> > >  how it is done in the rest of the file).
> > 
> > Adapted to be written the same way as the other comments.
> > 
> > > Missing ffmpeg-doc.texi docs.
> > 
> > Added.
> > 
> > Also:
> > 
> > - changed from -forced_key_frames to -force_key_frames: more consistent with
> >   other options (-force_fps) and the one I submitted to MPlayer;
> > 
> > - added the argument description to the option structure.
> > 
> > > BTW can you explain a scenario where using this option would be useful?
> > 
> > I want to use it to ensure that there is a seek point exactly at a place I
> > will probably want to jump precisely sometime, the major example would be
> > the end of an opening and beginning of the program proper. The scene change
> > detection system will often make it happen, but not always if there is a
> > fade-in.
> > 
> > Regards,
> > 
> > -- 
> >   Nicolas George
> 
> >  Changelog           |    1 +
> >  doc/ffmpeg-doc.texi |    6 ++++++
> >  ffmpeg.c            |   41 +++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 48 insertions(+)
> > 05d6ba65100bf40b88920e190ad54a3418b2664b  ffmpeg-forcekeyframe-20101016-2035-01-forcekeyframe.diff
> >  Changelog           |    1 +
> >  doc/ffmpeg-doc.texi |    6 ++++++
> >  ffmpeg.c            |   41 +++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 48 insertions(+), 0 deletions(-)
> 
> patch ok with me
> 
> maybe one of the regtests we have could be changed to use it so its tested

Applied, thanks for the patch Nicolas!
-- 
FFmpeg = Foolish and Funny Multipurpose Pitiless Elegant Geisha