[FFmpeg-devel] Fix mjpeg decoder runaway from internal buffer

Michael Niedermayer michaelni
Tue Oct 19 16:31:14 CEST 2010

On Tue, Oct 19, 2010 at 05:51:55PM +0400, Anatoliy Nenashev wrote:
> Hi!
> In some cases there is a situation when mjpeg decoder runaway from  
> allocated s->buffer.
> Usually it happens in VLC decoder for DC-AC coefficients when input  
> frame is cirrupted.
> In this case it is caused by "specific" garbage at the end of the memory  
> allocated for s->buffer.
> Here is a fix to prevent this situation.

i dont see how this would prevent overreading the buffer. And no i dont
care that on your computer with your sample this week it works.
unless you can show that this always works (which i doubt) its not
a correct solution. theres a check missing for the end of the buffer and or
the buffer is too small i would suspect

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101019/ffe7a4d0/attachment.pgp>

More information about the ffmpeg-devel mailing list