[FFmpeg-devel] [PATCH 2/2] Put the code for showing input and output streams and mapping in a separate function show_format_map().

Stefano Sabatini stefano.sabatini-lala
Sat Oct 30 20:35:22 CEST 2010


On date Saturday 2010-10-16 22:07:23 +0200, Michael Niedermayer encoded:
> On Sat, Oct 16, 2010 at 04:59:53PM +0200, Stefano Sabatini wrote:
> > Improve readability and decrease the size of the still huge
> > transcode_init() function.
> > ---
> >  ffmpeg.c |   53 ++++++++++++++++++++++++++++++-----------------------
> >  1 files changed, 30 insertions(+), 23 deletions(-)
> > 
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 045e2d5..acd136d 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -1935,6 +1935,35 @@ static AVInputStream **ist_table;
> >  static AVOutputStream **ost_table;
> >  static AVInputFile *file_table;
> >  
> > +static void show_format_map(void)
> 
> its ugly (and not only that but it also has practical issues)
> to pass void as argument and then use random global variables as arguments

Dropped.
-- 
FFmpeg = Fabulous and Frenzy Merciful Power Excellent Gorilla



More information about the ffmpeg-devel mailing list