[FFmpeg-devel] [PATCH] dsputil_mmx: add xmm registers to clobber list

[Ramiro Polla]

On Sun, Oct 31, 2010 at 10:02 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Sat, Oct 30, 2010 at 3:45 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>> $subj
> [..]
>> static void vorbis_inverse_coupling_sse(float *mag, float *ang, int blocksize)
>> {
>> ? ? int i;
>>
>> ? ? __asm__ volatile(
>> ? ? ? ? ? ? "movaps ?%0, ? ? %%xmm5 \n\t"
>> ? ? ? ? ::"m"(ff_pdw_80000000[0])
>> ? ? );
>> ? ? for(i=0; i<blocksize; i+=4) {
>> ? ? ? ? __asm__ volatile(
>> ? ? ? ? ? ? "movaps ?%0, ? ? %%xmm0 \n\t"
>
> This asm block should be merged (I know it's not your patch, but it's
> the same function).

It's svn diff -x -up's fault. It doesn't know what function it's
talking about when there are macros in between. The patch changes
MIX5, which is used by ac3_downmix_sse(), which doesn't set xmm
registers in separate blocks.

Maybe we could add to that Google Code-In list for people to merge asm
blocks such as these.