[FFmpeg-devel] [PATCH] Remove duplicate emms_c() calls

[Michael Niedermayer]

On Sun, Aug 29, 2010 at 05:48:16PM +0200, Aurelien Jacobs wrote:
> On Thu, Aug 26, 2010 at 06:06:23PM -0400, David Conrad wrote:
> > On Aug 26, 2010, at 6:01 PM, Alex Converse wrote:
> > 
> > > The following calls to emms_c() appear to be unnecessary. They all seem to
> > > duplicate the post video decode/encode emms call.
> > > 
> > > I verified that nothing breaks with "./configure --enable-gpl --disable-sse
> > > --extra-cflags=-m32 --extra-ldflags=-m32"
> > 
> > > Index: libavcodec/vp3.c
> > > ===================================================================
> > > --- libavcodec/vp3.c	(revision 24952)
> > > +++ libavcodec/vp3.c	(working copy)
> > > @@ -1336,7 +1336,6 @@
> > >      offset[2] = s->current_frame.linesize[2]*cy;
> > >      offset[3] = 0;
> > >  
> > > -    emms_c();
> > >      s->avctx->draw_horiz_band(s->avctx, &s->current_frame, offset, y, 3, h);
> > >      s->last_slice_end= y + h;
> > >  }
> > 
> > This (and the others like it) is needed; draw_horiz_band may be a user callback and thus use float.
> 
> Indeed. I've updated the patch, dropping the 2 hunks which were in this
> situation. I've also checked all the other hunks and the all looks good.
> 
> Aurel
>  4xm.c           |    2 --
>  asv1.c          |    3 ---
>  bink.c          |    1 -
>  cljr.c          |    4 ----
>  dv.c            |    4 ----
>  ffv1.c          |    3 ---
>  huffyuv.c       |    2 --
>  jpeglsenc.c     |    2 --
>  ljpegenc.c      |    2 --
>  mjpegdec.c      |    1 -
>  mpeg12.c        |    2 --
>  mpegvideo_enc.c |    2 --
>  snow.c          |    4 ----
>  vcr1.c          |    4 ----
>  14 files changed, 36 deletions(-)
> 79eca8513cdf091b143d8fb05efaadc379f14957  emms.diff


redundant emms_c does very little harm, lack of emms_c is hard to debug
and can be really annoying
its removial needs proof that its unneeded and in the mail that contains
the patch. putting the burden on the reviewer to proof it to be safe is
out of proportion to the gain of 1 line of code less.
also the patch should be generated with -p its essential for easy reviewing


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100902/a9fa4342/attachment.pgp>