[FFmpeg-devel] [PATCH 1/2] Rename FF_MM_ symbols related to MultiMedia CPU features as AV_CPU_MM_ symbols, as they are public, and move them from libavcodec/avcodec.h to libavutil/cpu.h.

[Michael Niedermayer]

On Mon, Aug 30, 2010 at 11:17:49AM +0200, Stefano Sabatini wrote:
> On date Monday 2010-08-30 10:54:39 +0200, Stefano Sabatini encoded:
> > On date Monday 2010-08-30 03:17:46 +0200, Luca Barbato encoded:
> > > On 08/30/2010 01:27 AM, Stefano Sabatini wrote:
> > > > On date Sunday 2010-08-29 23:59:35 +0100, M?ns Rullg?rd encoded:
> > > >> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > > > [...]
> > > >>> --- a/libavcodec/arm/dsputil_init_arm.c
> > > >>> +++ b/libavcodec/arm/dsputil_init_arm.c
> > > >>> @@ -75,7 +75,7 @@ static void simple_idct_arm_add(uint8_t *dest, int line_size, DCTELEM *block)
> > > >>>
> > > >>>  int mm_support(void)
> > > >>>  {
> > > >>> -    return HAVE_IWMMXT * FF_MM_IWMMXT;
> > > >>> +    return HAVE_IWMMXT * AV_CPU_MM_IWMMXT;
> > > >>>  }
> > > >>
> > > >> Is the MM part really needed?
> > > > 
> > > > Are not those flags related to MultiMedia extensions?
> > > 
> > > Most if not all are just simd instructions set that happen to be handy
> > > when doing multimedia, I'd drop that MM.
> > 
> > Updated.
> 
> Missing renames, fixed.
> -- 
> FFmpeg = Freak Faithful Mortal Purposeless Evanescent Gorilla

>  libavcodec/arm/dsputil_init_arm.c |    2 -
>  libavcodec/arm/dsputil_iwmmxt.c   |    7 ++--
>  libavcodec/arm/mpegvideo_iwmmxt.c |    3 +
>  libavcodec/audioconvert.h         |    3 +
>  libavcodec/avcodec.h              |   36 +++++++++------------
>  libavcodec/dct-test.c             |   22 ++++++------
>  libavcodec/h263dec.c              |    2 -
>  libavcodec/motion-test.c          |    6 +--
>  libavcodec/ppc/dsputil_ppc.c      |    2 -
>  libavcodec/x86/cavsdsp_mmx.c      |    4 +-
>  libavcodec/x86/cpuid.c            |   52 +++++++++++++++---------------
>  libavcodec/x86/dnxhd_mmx.c        |    2 -
>  libavcodec/x86/dsputil_mmx.c      |   65 +++++++++++++++++++-------------------
>  libavcodec/x86/dsputilenc_mmx.c   |   18 +++++-----
>  libavcodec/x86/fft.c              |    8 ++--
>  libavcodec/x86/h264dsp_mmx.c      |   10 ++---
>  libavcodec/x86/motion_est_mmx.c   |    6 +--
>  libavcodec/x86/mpegaudiodec_mmx.c |    2 -
>  libavcodec/x86/mpegvideo_mmx.c    |   10 ++---
>  libavcodec/x86/snowdsp_mmx.c      |    7 ++--
>  libavcodec/x86/vc1dsp_mmx.c       |   12 +++----
>  libavcodec/x86/vp56dsp_init.c     |    4 +-
>  libavcodec/x86/vp8dsp-init.c      |   14 ++++----
>  libavutil/Makefile                |    1 
>  libavutil/cpu.h                   |   44 +++++++++++++++++++++++++
>  25 files changed, 195 insertions(+), 147 deletions(-)
> a0cecdd6737e9e093727d92d657eb9973aa525fd  0001-Rename-FF_MM_-symbols-related-to-MultiMedia-CPU-feat.patch
> From d83b1d30cbe7dd71ff2fc60fdccf6734db6208c6 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sun, 29 Aug 2010 23:15:30 +0200
> Subject: [PATCH 1/2] Rename FF_MM_ symbols related to MultiMedia CPU features as AV_CPU_
>  symbols, and move them from libavcodec/avcodec.h to libavutil/cpu.h.

looks ok if tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100902/773d2a1d/attachment.pgp>