[FFmpeg-devel] [PATCH] fix --enable-runtime-cpudetect --disable-amd3dnow compilation

[Ramiro Polla]

On Fri, Sep 3, 2010 at 7:06 PM, Alexander Strange <astrange at ithinksw.com> wrote:
> CC ? ? ?libswscale/swscale.o
> ...
> libswscale/swscale.c: In function ?ff_getSwsFunc?:
> libswscale/swscale.c:1268: warning: implicit declaration of function ?sws_init_swScale_3DNow?
> libswscale/swscale.c:1269: error: ?swScale_3DNow? undeclared (first use in this function)
> libswscale/swscale.c:1269: error: (Each undeclared identifier is reported only once
> libswscale/swscale.c:1269: error: for each function it appears in.)
>
> Alternatively, it could declare prototypes for sws_init_swScale_3DNow / swScale_3DNow even if they aren't being compiled.
> That would let us use "if (COMPILE_TEMPLATE_AMD3DNOW && flags & SWS_CPU_CAPS_3DNOW)" instead of #ifdefs. But it might make some of the other templating more complex.

Since we're on the subject, do we really need this complexity in
swscale? dsputils always builds c and optimized code, then selects in
the init function. swscale has one extra layer of complexity in which
you can disable runtime cpu detection and it would only compile for
the fastest optimization available.

Could we drop this and always enable runtime cpu detection like dsputil does?