[FFmpeg-devel] [PATCH] mkv 0-byte integer parsing

[Aurelien Jacobs]

On Sun, Sep 05, 2010 at 05:51:53PM +0200, Reimar D?ffinger wrote:
> On Sun, Sep 05, 2010 at 04:22:43PM +0200, Sebastian Hagen wrote:
> > Index: libavformat/matroskadec.c
> > ===================================================================
> > --- libavformat/matroskadec.c	(revision 25042)
> > +++ libavformat/matroskadec.c	(working copy)
> > @@ -583,7 +583,7 @@
> >  {
> >      int n = 0;
> >  
> > -    if (size < 1 || size > 8)
> > +    if (size > 8)
> >          return AVERROR_INVALIDDATA;
> 
> AFAIK this makes it also accept negative size (and it seems it
> always accepted a length value like
> 0xffff00000001
> treating it as "1".
> Attached patch adds a length check for that case (this is independant
> of this patch though).

Looks interesting and pretty good, but I would like to give it a deeper
look.
Unfortunately, it won't be before quite some time. So if you think it's
really important, you can apply it, and I will review/modify afterward.

Aurel