[FFmpeg-devel] [RFC/PATCH 5/8] tidsp: add init/close

Felipe Contreras felipe.contreras
Tue Sep 7 12:33:21 CEST 2010


On Tue, Sep 7, 2010 at 1:09 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Sep 06, 2010 at 01:15:32AM +0300, Felipe Contreras wrote:
>> Signed-off-by: Felipe Contreras <felipe.contreras at gmail.com>
>> ---
>> ?libavcodec/tidsp_mpeg4.c | ? 28 ++++++++++++++++++++++++++++
>> ?1 files changed, 28 insertions(+), 0 deletions(-)
>>
>> diff --git a/libavcodec/tidsp_mpeg4.c b/libavcodec/tidsp_mpeg4.c
>> index 3c3190d..1ed2e90 100644
>> --- a/libavcodec/tidsp_mpeg4.c
>> +++ b/libavcodec/tidsp_mpeg4.c
>> @@ -8,8 +8,34 @@
>> ? * in the packaging of this file.
>> ? */
>>
>> +#include "tidsp/tidsp.h"
>> +
>> ?#include "avcodec.h"
>>
>> +struct td_av_context {
>> + ? ? struct td_context *td_ctx;
>> +};
>
> why this wraper struct?

See patch 8/8: tidsp: process buffers.

The code in the 'tidsp' directory (and thus struct td_context) is
supposed to be independent of FFmpeg, and according to other people's
comments I should strip out and make an independent library.

> and tabs are forbidden in ffmpeg

Right, this has been mentioned before. Will fix.

-- 
Felipe Contreras



More information about the ffmpeg-devel mailing list