[FFmpeg-devel] [PATCH] Assign unique values to AV_CPU_FLAG_IWMMXT and AV_CPU_FLAG_ALTIVEC.

Ronald S. Bultje rsbultje
Wed Sep 8 15:55:04 CEST 2010


Hi,

On Wed, Sep 8, 2010 at 7:44 AM, Janne Grunau <janne-ffmpeg at jannau.net> wrote:
> if (mm_flags && FF_MM_MMX)
> ? ? ? ?cpuflags |= SWS_CPU_CAPS_MMX;
> if (mm_flags && FF_MM_ALTIVEC)
> ? ? ? ?cpuflags |= SWS_CPU_CAPS_ALTIVEC;
>
> had strange results since SWS_CPU_CAPS_MMX != SWS_CPU_CAPS_ALTIVEC.
> Easily solveable with adding HAVE_(MMX|ALTIVEC) && to the ifs.

This should all be under ARCH_PPC or HAVE_MMX and similar. x86-family
CPUs supporting altivec don't exist.

(And why && instead of &?)

Ronald



More information about the ffmpeg-devel mailing list