[FFmpeg-devel] [PATCH 9/10] GXF Encoder Fixes and HD support (patch broken up)

[Baptiste Coudurier]

On 09/08/2010 06:41 PM, Reuben Martin wrote:
> Yo, back on Wednesday, September 08, 2010 Reuben Martin was all like:
>> 09-gxf__disabled_AVCI.patch
>>
>> FEATURE - OPTIONAL: This is a disabled chunck of code that would enable AVCI support. Two reasons it's not enabled: 1) I have no idea if the UMF media header for it uses the same mpeg header as MPEG1 and MPEG2 or if it has it's own unique media header. 2) Probably not a good idea to attempt encoding until ffmpeg can at least decode the AVCI samples correctly.
>>
>> 09-gxf__disabled_AVCI.patch
>>
>>
>> --- ffmpeg-old/libavformat/gxfenc.c	2010-09-08 17:27:04.569000110 -0500
>> +++ ffmpeg-new/libavformat/gxfenc.c	2010-09-08 17:28:29.148000128 -0500
>> @@ -889,6 +889,14 @@
>>                       media_info = 'D';
>>                   }
>>                   break;
>> +#if 0
>> +            case CODEC_ID_H264:
>> +                    sc->media_type = 26;
>> +                    gxf->flags |=  0x02000000;
>> +                    media_info = 'I';
>> +                    sc->track_type = 11;
>> +                break;
>> +#endif
>>               default:
>>                   av_log(s, AV_LOG_ERROR, "video codec not supported\n");
>>                   return -1;
>>
>>

I'm not a big fan of disabled code in svn.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org