[FFmpeg-devel] [PATCH 3/10] GXF Encoder Fixes and HD support (patch broken up)

Reuben Martin reuben.m
Mon Sep 20 23:59:25 CEST 2010


Yo, back on Thursday, September 09, 2010 Baptiste Coudurier was all like:
> On 09/08/2010 06:36 PM, Reuben Martin wrote:
> > Yo, back on Wednesday, September 08, 2010 Reuben Martin was all like:
> >> 03-gxf__flt_over_limit_error.patch
> >>
> >> BUG: There was always an error the the number of FLT packets was over the limit by one. This fixes that error. Mostly cosmetic, I don't think it was causing any (noticeable) playback issues.
> >>
> >>
> >> 03-gxf__flt_over_limit_error.patch
> >>
> >>
> >> --- ffmpeg-old/libavformat/gxfenc.c	2010-09-08 16:47:56.016000087 -0500
> >> +++ ffmpeg-new/libavformat/gxfenc.c	2010-09-08 16:48:04.774000099 -0500
> >> @@ -371,7 +371,7 @@
> >>       gxf_write_packet_header(pb, PKT_FLT);
> >>
> >>       put_le32(pb, fields_per_flt); /* number of fields */
> >> -    put_le32(pb, flt_entries); /* number of active flt entries */
> >> +    put_le32(pb, flt_entries + 1); /* number of active flt entries */
> 
> Look above, there is:
>      int flt_entries = gxf->nb_fields / fields_per_flt - 1;
> 
> This seems weird, I'll double check this.
> 
> 

Updated with regression test diff. 
(regression diff is for applying this patch individually to trunk. Regression test diff will be different if applied on top of patch #01)

-Reuben



More information about the ffmpeg-devel mailing list