[FFmpeg-devel] [PATCH2/3] asfdec.c doesn't detect aspect ratio properly in some case

Michael Niedermayer michaelni
Tue Sep 21 22:02:16 CEST 2010


On Tue, Sep 21, 2010 at 10:15:38AM -0700, Richard Buteau wrote:
> Hi all,
> In some case ASF file don't have aspect ratio set in
> ff_asf_metadata_header but in ff_asf_extended_content_header.
> The results was a stretch out file.
> This patch extract that aspect ratio info and pass it down to the
> container.
> Richard
> 
> 
 [...]
Content-Description: asfAR.patch.txt
> diff -uNr -x .svn -x '*.d' ffmpeg/libavformat/asfdec.c ffmpeg.asfAR/libavformat/asfdec.c
> --- ffmpeg/libavformat/asfdec.c	2010-09-14 13:04:36.000000000 -0500
> +++ ffmpeg.asfAR/libavformat/asfdec.c	2010-09-21 11:54:10.000000000 -0500
> @@ -467,6 +467,12 @@
>                      value_len  = get_le16(pb);
>                      if (!value_type && value_len%2)
>                          value_len += 1;
> +                    int stream_num=0; //Ideally we should find the video stream and set it there. My sample has that stream set to 0 maybe that mean the container.

breaks gcc 2.95
try tools/patcheck please
and assigning global information to just one stream is wrong

and please upload the asf file that needs this


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100921/48286253/attachment.pgp>



More information about the ffmpeg-devel mailing list