[FFmpeg-devel] [PATCH2/3] asfdec.c doesn't detectaspectratio properly in some case

Carl Eugen Hoyos cehoyos
Wed Sep 22 17:09:54 CEST 2010


Richard Buteau <rbuteau <at> rgbnetworks.com> writes:

[...]

> +    AVRational dar_ech;
>      uint32_t bitrate[128];
> 
>      memset(dar, 0, sizeof(dar));
> +    dar_ech.den=0;
> +    dar_ech.num=0;

I think you can merge declaration and initialisation here.

[...]

> -                    get_tag(s, name, value_type, value_len);

> +                        get_tag(s, name, value_type, value_len);

While it's only one line, I still believe the patch is more readable if you do
not re-indent it.

Carl Eugen




More information about the ffmpeg-devel mailing list